Warnings signed unsigned #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been rebased over master and updated to accommodate #407 |
| { | ||
| if (nRndPos1 == nRndPos2) | ||
| return; | ||
|
|
||
| assert(nRndPos1 >= 0 && nRndPos2 >= 0); |
There was a problem hiding this comment.
Is this meant to be removed?
There was a problem hiding this comment.
Yes, no, either really... They removed it from bitcoin but to be honest I don't see a problem with simply casting 0 to a unsigned integer and keeping it.
There was a problem hiding this comment.
Ahh right. Happy to leave it removed. Whichever you want :)
There was a problem hiding this comment.
Honestly I'm not sure why they removed it, it may be safer to retain it and cast the 0 as I said. I'm really not sure.
this was in bitcoinrpc.cpp but has been moved since the original patch
|
This has been rebased over master do to merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of PR #229