Move GetStartOnSystemStartup and SetStartOnSystemStartup to GUI code #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again I'll confirm Windows builds and running the wallet |
|
This has been rebased over master @MitchellCash if you have already tested this please test it again. |
|
Sorry I missed testing this before it conflicted again. I will await your next rebase over master and will make this the next thing I test. |
|
@MitchellCash I hadn't even noticed it was broken lol. Rebased over master to accommodate #391 |
|
Like the Bitcoin commit shlwapi.h can be removed from util.cpp after your changes as it looks like we've move any concatenation out from that file. I've already checked without shlwapi.h and it compiles fine on Windows and works as expected. |
|
removed and tested (15 minutes) |
|
Looks good to me from here. |
|
squashed and confirmed gitian builds (50 minutes) |
scroogemcdev
added a commit
that referenced
this pull request
Dec 21, 2015
Move GetStartOnSystemStartup and SetStartOnSystemStartup to GUI code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: bitcoin/bitcoin#1178