Fix for parsing relative server URLs #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Sep 7, 2020
| @@ -83,7 +83,7 @@ paths: | |||
| $ref: "#/components/schemas/Error" | |||
| servers: | |||
| - url: http://petstore.swagger.io | |||
| - url: http://petstore.swagger.io/staging/ | |||
| - url: /staging/ | |||
| components: | |||
There was a problem hiding this comment.
Would be better to add additional entry and not replace existing one .
There was a problem hiding this comment.
i'd also like to see a test that checks that all urls are parsed correctly
kibertoad
reviewed
Sep 7, 2020
| @@ -37,7 +37,8 @@ function buildValidations(referenced, dereferenced, receivedOptions) { | |||
| const schemas = {}; | |||
|
|
|||
| const basePaths = dereferenced.servers && dereferenced.servers.length | |||
| ? dereferenced.servers.map(({ url }) => new URL(url).pathname) | |||
| // dummy base path is required by URL constructor when server url is not absolute | |||
| ? dereferenced.servers.map(({ url }) => new URL(url, 'http://example.com').pathname) | |||
There was a problem hiding this comment.
Would matching work correctly with this hardcoded value? Definitely needs a new e2e test for this case of matching.
|
Sorry, we're no longer using this package so it's unlikely I'll have time to do the update. Happy for someone else to take it over of course. Thanks. |
|
Hi @tamlyn , are we continuing with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server URL is relative like
/some-paththen theURLconstructor throws an error because it doesn't know how to resolve it. Passing a dummy base URL to the constructor avoids the problem.