allow backfilling of counts and rpkm without triggering preprocessing #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally we would just compare the log2cpm with the new one and trigger post-processing if they differ. I'll write some unit tests for the CLI. |
arteymix
reviewed
Jul 24, 2023
|
I'll write unit tests instead of adding an integration test because it's impractical to check if the preprocessing service has been interacted with. |
This is needed to write unit tests for DataUpdater.
arteymix
reviewed
Jul 25, 2023
| verify( expressionExperimentService, times( 2 ) ).addRawVectors( same( ee ), any() ); | ||
| dataUpdater.addCountData( ee, ad, countMatrix, rpkmMatrix, 30, false, false, true ); | ||
| verify( expressionExperimentService ).replaceRawVectors( same( ee ), any() ); | ||
| verifyNoMoreInteractions( preprocessorService ); |
There was a problem hiding this comment.
@ppavlidis I've added the unit test here. It checks that the preprocessor service is only invoked once.
I'll add a test to see how differing library sizes are handled. Let me know if you want other cases covered.
arteymix
reviewed
Jul 25, 2023
| ba.setSequencePairedReads( isPairedReads ); | ||
| } | ||
|
|
||
| if ( ba.getSequenceReadCount() != null && ba.getSequenceReadCount() != librarySize && requireExistingLibrarySizesMatch ) { |
There was a problem hiding this comment.
We need a test case for this specific condition.
arteymix
force-pushed
the
development
branch
2 times, most recently
from
84692c7 to
e0ec3da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address curation issue 362.
By using the the
noLog2cpmoption for RNASeqDataAddCli should allow us to backfill counts and rpkm for old data sets in a minimally-invasive way.Needs testing.
TODO