-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
different types of submodels pointing to the same Model #429
Comments
Just wondering, why would you have two keys point to the same model? |
Taking from the above example, If I have a Dog and a Wolf, each should be represented by the Carnivore model but I might want to show them by using different views. So basically, you might want to reuse the type attribute to assign a different view to a model. Otherwise, you are forced to create a model (or a dummy model that inherits from the main one) for each such type. |
* upstream/master: (35 commits) Upgrade qunit Fix subModels not being populated properly on Underscore 1.6.0, due to `_.each` api change. Fire change events right away if we're not in a nested scenario. Fixes PaulUithol#427 Document `store.unregister` `store.unregister` now also accepts collections or a model type Change `findOrCreate` to pass `parsedAttributes` to `build`, and adjust tests to reflect change. Remove unnecessary locking Update change log Add test for models not being added to store until they get an id Change where we listen to `relational:unregister`. Only add models with an id to the store. Closes PaulUithol#411 Fix a bug in the (crude) performance test Add a small test for `clear` Fix collection return values when setting/removing `[]` and `null`. Ref PaulUithol#419 Clarify the behavior of `findOrCreate` when it just a receives a scalar value. Ref PaulUithol#399 Proper return values on collection methods for Backbone 1.1. Closes PaulUithol#419 Submodels: accommodate multiple 'type' keys for the same submodel. Closes PaulUithol#429 Hmm, fix spaces/tabs mix in the example Update a few version numbers in the docs to 0.8.7 Backbone-relational 0.8.7 ...
When using different keys (types) pointing to the same model , only one of the key ended up pointing to the actual model, the other is discarded, and as a result when using type "koko", we get the Mammal Model.
This bug can be avoided when using a different model class for Koko, I presume.
The text was updated successfully, but these errors were encountered: