Adding support for UNO-R4 boards #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `architectures` field of the library.properties metadata file specifies a list of architectures supported by the library. Previously, the `renesas_uno` architecture was not included in this list, even though that architecture is supported by the library. This resulted in several undesirable outcomes when compiling the library for boards of that architecture: * Display of a misleading warning when compiling the library: WARNING: library TimerOne claims to run on avr architecture(s) and may be incompatible with your current board which runs on renesas_uno architecture(s). * Library discovery phase of the sketch build system giving higher priority to other installed libraries matching an #include directive intended to target this library. * Library's examples placed under the Arduino IDE 1.x File > Examples > INCOMPATIBLE menu. These problems are resolved by adding the missing architectures to the `architectures` field. When installed via Boards manager, the "Arduino R4 UNO Boards" platform has the architecture `renesas_uno`. This platform is part of the `arduino/ArduinoCore-renesas` repository, which provides support for other boards based on Renesas microcontrollers in addition to the UNO R4 family. When the platform is installed manually for development or beta testing, the `renesas_uno` architecture is not appropriate and so the convention is to instead use the general `renesas` architecture for manual installations of the platform. For this reason, the `renesas` architecture was also added to the field in order to support the use of the library with manually installed copies of the platform in addition to Boards Manager installations.
Update metadata to reflect addition of support for UNO R4 boards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
622ac13 will add support except for the PWM functions for the UNO-R4 boards. There have been a number of threads mentioning problems with third party libraries that depend on TimerOne for timer functions which are broken for the R4 boards. This pull should resolve that.
This is my first contribution to another library. If I'm out of line or doing it wrong, please let me know. I really want to learn the system.