-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Off-by-one bug in readRect #29
Comments
mudaltsov
added a commit
to mudaltsov/ILI9341_t3
that referenced
this issue
Dec 2, 2016
This fixes PaulStoffregen#29 The implementation of readRect had an issue where it would not correctly read the last pixel from the screen. This was caused by an overflow in the RX FIFO while waiting for the EOQ flag in the last transmitted byte. The loop only counted transmitted bytes, so it would fill up the TX FIFO and not wait until the transfer actually happened. Waiting for EOQ competed the queued transfers and overflowed the RX FIFO since nothing was reading from it. The new implementation explicitly tracks the number of RX and TX bytes to ensure that all bytes are correctly transmitted and received. A few ideas have been borrowed from KurtE/ILI9341_t3n as well: * Each byte is received independently and stored in a 3-byte array, which is converted and written to the buffer once all 3 colors have been received. * The TX FIFO is kept full throughout the function to avoid the delay between the dummy byte and the first pixel byte. Instead of using EOQ for the dummy byte, the results from queued commands and the dummy byte are skipped.
mudaltsov
added a commit
to mudaltsov/ILI9341_t3n
that referenced
this issue
Dec 3, 2016
(Ported from ILI9341_t3, with appropriate changes to use SPIN) This fixes PaulStoffregen/ILI9341_t3#29 The implementation of readRect had an issue where it would not correctly read the last pixel from the screen. This was caused by an overflow in the RX FIFO while waiting for the EOQ flag in the last transmitted byte. The loop only counted transmitted bytes, so it would fill up the TX FIFO and not wait until the transfer actually happened. Waiting for EOQ competed the queued transfers and overflowed the RX FIFO since nothing was reading from it. The new implementation explicitly tracks the number of RX and TX bytes to ensure that all bytes are correctly transmitted and received. A few ideas have been borrowed from KurtE/ILI9341_t3n as well: * Each byte is received independently and stored in a 3-byte array, which is converted and written to the buffer once all 3 colors have been received. * The TX FIFO is kept full throughout the function to avoid the delay between the dummy byte and the first pixel byte. Instead of using EOQ for the dummy byte, the results from queued commands and the dummy byte are skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I found that
readRect
will never read the last pixel.The below sketch reproduces the problem using the Teensy 3.1, the Adafruit shield and the latest stable Teensyduino.
I fixed it by just incrementing
c
inreadRect
, but that's probably not the correct solution.It seems on the last byte you clear the
SR
register, which makes the check if there are 3 bytes in the FIFO fail, but not knowing the meaning of all the SPI registers I was unable to quickly see the correct solution.The text was updated successfully, but these errors were encountered: