Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the envoy permission system to work for whole target contracts instead of just target functions #73

Closed
PaulRBerg opened this issue Feb 23, 2023 · 0 comments
Closed

Refactor the envoy permission system to work for whole target contracts instead of just target functions #73

PaulRBerg opened this issue Feb 23, 2023 · 0 comments
Milestone
V4

Comments

@PaulRBerg
Copy link
Owner

PaulRBerg commented Feb 23, 2023 •
edited
Loading

As discussed with @SolcAndMe in #67, there is not much value in keeping the envoy permission system as it is currently implemented. It makes sense to just give permission to whole target contracts.

This would also help reduce the deployment size.
@PaulRBerg PaulRBerg added this to the V4 milestone Feb 23, 2023
PaulRBerg added a commit that referenced this issue Feb 23, 2023
@PaulRBerg
refactor: simplify envoy system
0347495 
closes #73
PaulRBerg added a commit that referenced this issue Feb 23, 2023
@PaulRBerg
refactor: simplify envoy system
2207486 
docs: say "provided" instead of "given"
docs: document "TransferOwnership" event in NatSpec
refactor: order events alphabetically

closes #73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V4
Development

No branches or pull requests
1 participant
@PaulRBerg