Fix constructor in PRBProxy.sol contract

[luislucena16]

looking a bit more at the contract, I see an unchecked return value in the constructor inside PRBPorxy. sol:

    constructor() {
        registry = IPRBProxyRegistry(msg.sender);
        (address owner_, address target, bytes memory data) = registry.constructorParams();
        owner = owner_;
        if (target != address(0)) {
            _execute(target, data);
        }
    }

having in mind that _execute function return a bytes value, but this process is not checked, a new error would also be added to revert if it fails!

[PaulRBerg]

The design is intentional. The point is to let _execute handle the revert.

a new error would also be added to revert if it fails!

What is your suggestion, more specifically? A code snippet would be helpful

[luislucena16]

ok, now I understand! the goal is to take the error in _execute, I thought you were looking to do it there directly, something like this:

constructor() {
    registry = IPRBProxyRegistry(msg.sender);
    (address owner_, address target, bytes memory data) = registry.constructorParams();
    owner = owner_;
    if (target != address(0)) {
        bytes memory response = _execute(target, data);
        if (response.length == 0) {
            revert ExecutionFailed();
        }
    }
}