Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix examples HMR #360

Merged
merged 1 commit into from
Aug 20, 2017
Merged

Fix examples HMR #360

merged 1 commit into from
Aug 20, 2017

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Aug 18, 2017 •
edited
Loading

Move app into an App component in example/components/app.js and create index.js to handle HMR.

Most of that stuff was deprecated and did not work.

@PaulLeCam
Copy link
Owner

Thanks!
Yes I haven't changed this setup since I added it, great to have it fixed!

Could you update your PR to resolve the conflicts with master please?

@tusbar
Copy link
Contributor Author

tusbar commented Aug 20, 2017

@PaulLeCam done. :)

@PaulLeCam PaulLeCam merged commit 2c75bf6 into PaulLeCam:master Aug 20, 2017
@PaulLeCam
Copy link
Owner

Thanks!

@tusbar tusbar deleted the example-webpack branch August 20, 2017 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tusbar @PaulLeCam