LayersControl does not pass map props to children #142

Dahlgren · 2016-04-16T13:49:14Z

Map is not passed to children of LayersControl. This breaks the behaviour defined for custom components.

Could not get unmock to work properly and it always passed the test due to ChildComponent not being rendered. My failed attempt at unmock looked like this,

jest.dontMock('../src/LayersControl');
jest.dontMock('../src/Map');
jest.dontMock('../src/MapControl');
jest.dontMock('../src/types/bounds');
jest.dontMock('../src/types/children');
jest.dontMock('../src/types/index');
jest.dontMock('../src/types/latlng');
jest.dontMock('../src/types/controlPosition');
jest.dontMock('../src/types/layerContainer');

PaulLeCam · 2016-04-17T09:26:42Z

Thanks!
I just published it as v0.11.1.

* Set source argument in Popup creation * v0.10.1 * Animate panning and zooming * v0.10.2 * Lint 'object destructuring filter' consistently The pattern ```const { map, url, ...props } = this.props``` usually failed during linting, because the ```map``` variable is defined but not used. After adding the ```"varsIgnorePattern": "^_"``` option to the ```no-unused-vars``` rule, unused properies can be marked as: ```const { map: _, url, ...props } = this.props```. I also updated the eslint and babel-eslint dependencies, because of some relevant bugfixes. * Add babel-plugin-lodash * Introduce the concept of 'layer container', as a unified interface for L.Map and L.LayerGroup. * v0.11 - new LayersControl * Component-based LayersControl * Deprecate `onLeaflet...` format for events * React v15 * LayersControl does not pass map props to children (#142) * v0.11.1 * v0.11.2 * Add dynamic draggable props to Marker (#148) * expose ability to toggle marker's draggable status * fix indentation * v0.11.3

* Set source argument in Popup creation * v0.10.1 * Animate panning and zooming * v0.10.2 * Lint 'object destructuring filter' consistently The pattern ```const { map, url, ...props } = this.props``` usually failed during linting, because the ```map``` variable is defined but not used. After adding the ```"varsIgnorePattern": "^_"``` option to the ```no-unused-vars``` rule, unused properies can be marked as: ```const { map: _, url, ...props } = this.props```. I also updated the eslint and babel-eslint dependencies, because of some relevant bugfixes. * Add babel-plugin-lodash * Introduce the concept of 'layer container', as a unified interface for L.Map and L.LayerGroup. * v0.11 - new LayersControl * Component-based LayersControl * Deprecate `onLeaflet...` format for events * React v15 * LayersControl does not pass map props to children (#142) * v0.11.1 * v0.11.2 * Add dynamic draggable props to Marker (#148) * expose ability to toggle marker's draggable status * fix indentation * v0.11.3 * Changes removeFrom to remove in MapControl * Removes MultiPolyline; multipolylines are now supported by Polyline * Removes MultiPolygon; multipolygons are now supported by Polygon * Removes CanvasTileLayer, which has been removed from leaflet * Updates Circle instantiator to use new format

LayersControl does not pass map props to children

076df3a

PaulLeCam merged commit 018f1f9 into PaulLeCam:master Apr 17, 2016

Dahlgren deleted the bugfix/layers-control-props-map branch April 17, 2016 11:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LayersControl does not pass map props to children #142

LayersControl does not pass map props to children #142

Dahlgren commented Apr 16, 2016

PaulLeCam commented Apr 17, 2016

LayersControl does not pass map props to children #142

LayersControl does not pass map props to children #142

Conversation

Dahlgren commented Apr 16, 2016

PaulLeCam commented Apr 17, 2016