Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 todo #87

Closed
16 of 25 tasks
PaulLeCam opened this issue Oct 29, 2015 · 8 comments
Closed
16 of 25 tasks

v1 todo #87

PaulLeCam opened this issue Oct 29, 2015 · 8 comments
Milestone

Comments

@PaulLeCam
Copy link
Owner

PaulLeCam commented Oct 29, 2015

Must have

  • UMD build (#29)
  • Support for Controls (#81)
    • Zoom
    • Attribution
    • Layers
    • Scale
  • Contributing guidelines
  • Remove support for onLeaflet... events
    • Add deprecation warning in previous release
  • Extract docs out of readme, split in different sections
  • Remove support for getLeafletElement() method
    • Add deprecation warning in previous release
  • Support only React v15+
  • Leaflet v1 support (#66)

Nice to have

  • Website
    • Getting started
    • API
    • Examples
  • Examples for each component
  • Advanced examples (Redux, Rx...)
  • Tutorial for creating custom components
    • Reference implementation for plugin integration
@PaulLeCam PaulLeCam added this to the v1.0 milestone Oct 29, 2015
@jonboiser
Copy link
Contributor

Hi Paul,

I like the potential of this library for quickly bootstrapping geospatial apps written in React. Are there are any tasks you can use help with?

@PaulLeCam
Copy link
Owner Author

Hi @jonboiser, thanks for asking!

I think adding the attribution, layers and scale controls is the next priority. It shouldn't be a lot of work, just make sure they behave as expected.

Leaflet v1 support is tricky because I want to have it as soon as it's stable, but the current betas seem to change the APIs so I'm not sure it's worth investing time on it.

@jonboiser
Copy link
Contributor

Cool. I'll take a look at how you've implemented the Zoom control. I think I can help with the docs and website, once I play around with the library. At my company, we started a similar project for the ArcGIS JS API and Leaflet, but think we should deprecate the Leaflet piece, since this library is available.

@jonboiser
Copy link
Contributor

I pushed some code for the AttributionControl to my fork. It seems like coding the other controls will be pretty much the same. I'll tackle the others during the week and submit a PR.

@snario
Copy link

snario commented Mar 4, 2016

What's the progress like on this?

@PaulLeCam
Copy link
Owner Author

Mostly waiting on a RC of Leaflet v1 to start adapting what needs to be, and the final v1 release to effectively version this lib as v1 as well.

@jampy
Copy link

jampy commented Jul 27, 2016

Any news on this, since meanwhile there is even a second RC available?

@PaulLeCam
Copy link
Owner Author

Closing this issue, please go to the v1 release plan for more information about this future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants