Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 release plan #197

Closed
PaulLeCam opened this issue Jul 28, 2016 · 11 comments
Closed

v1 release plan #197

PaulLeCam opened this issue Jul 28, 2016 · 11 comments
Milestone

Comments

@PaulLeCam
Copy link
Owner

PaulLeCam commented Jul 28, 2016

Now that Leaflet v1 is well under way and React started to use major versions, React-Leaflet will move to semantic versioning as well, which means:

  • Only Leaflet v1+ will be supported, v0.12 of React-Leaflet will be the last version compatible with Leaflet v0.7.
  • Only React v15+ will be supported. It's likely React v0.14 would still work fine but v15 has been released for a while so most apps should already be using it anyways.
  • React follows semantic versioning and until now has also made new releases supporting the previous release API with eventual warnings, so in theory React v16 should not need a new major version of React-Leaflet. Hopefully Leaflet will also be strict in respecting semantic versioning, but otherwise React-Leaflet will apply it anyways, meaning if Leaflet v1.1 has a breaking API change affecting React-Leaflet, it would be supported in React-Leaflet v2.0.
  • Until Leaflet v1 final is released, React-Leaflet v1 will only have beta releases (available on npm with the next tag) for as long as there bugfixes and features to add. Once Leaflet v1 is finally released and if there is no pending issue with React-Leaflet, a first release candidate will be made, with other ones if necessary until the library is stable enough for a final v1 release.

Changes can be tracked in this pull request and the v1.0 milestone.
Once beta releases are published, please try them as much as possible to make sure most issues get reported and fixed before the stable release!

If you have any question or suggestion regarding this release plan, please feel free to comment below.

@PaulLeCam PaulLeCam added this to the v1.0 milestone Jul 28, 2016
@PaulLeCam PaulLeCam mentioned this issue Jul 28, 2016
25 tasks
@Dahlgren
Copy link
Contributor

Leaflet 1.0 was just released, http://leafletjs.com/2016/09/27/leaflet-1.0-final.html 🎉

@mbritton
Copy link

Thanks for the excellent work. Is there an ETA on the rc for react-leaflet that supports the complete Leaflet v1 feature set?

@zavan
Copy link

zavan commented Sep 28, 2016

I upgraded from leaflet rc3 to final and now i'm getting:

GET http://cdnjs.cloudflare.com/ajax/libs/leaflet/1.0.0-rc.3/imagesmarker-icon.png 404 (Not Found)
GET http://cdnjs.cloudflare.com/ajax/libs/leaflet/1.0.0-rc.3/imagesmarker-shadow.png 404 (Not Found)

When rendering markers:

<div class="leaflet-pane leaflet-marker-pane">
  <img src="//cdnjs.cloudflare.com/ajax/libs/leaflet/1.0.0-rc.3/imagesmarker-icon.png" class="leaflet-marker-icon leaflet-zoom-animated leaflet-interactive" tabindex="0" style="margin-left: -12px; margin-top: -41px; width: 25px; height: 41px; transform: translate3d(605px, 190px, 0px); z-index: 190; outline: none;">
</div>

Downgrading to rc3 works.
The url is different: http://cdnjs.cloudflare.com/ajax/libs/leaflet/1.0.0-rc.3/images/marker-icon.png

@Dahlgren
Copy link
Contributor

See #229

@PaulLeCam
Copy link
Owner Author

v1.0.0 RC 1 released, still under the "next" tag.

@PaulLeCam
Copy link
Owner Author

v1.0.0 RC 2 released, please try it out!

@tconroy
Copy link

tconroy commented Nov 7, 2016

Hey there! great work on these components, they're pretty amazing. Was wondering if you had an ETA on the v1 release? I noticed there's an open PR regarding it ( but appears to be a WIP? ). Going to be using this guy in a production app within a few weeks and would love to use 1.0.

@prewk
Copy link

prewk commented Nov 8, 2016

Hi, where do you want the RC2 bugs reported? In the PR?

@PaulLeCam
Copy link
Owner Author

Preferably as new issues please, make sure to indicate the versions of the libraries you are using, thanks!

@PaulLeCam
Copy link
Owner Author

v1 is here! https://github.com/PaulLeCam/react-leaflet/releases/tag/v1.0.0

@tconroy
Copy link

tconroy commented Nov 15, 2016

awesome work, @PaulLeCam! 👏 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants