Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with GHC-9.0 #22

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Conversation

recursion-ninja
Copy link
Contributor

Starting with ghc-9.0, there are new whitepspacing rules around "bang patterns" (!) to remove ambiguity in niche situations with infix operators/constructors.

Currently Decimal does not build with the ghc-9.0 release candidate because there is whitespace in the strict data constructor:

Configuring library for Decimal-0.5.1..
Preprocessing library for Decimal-0.5.1..
Building library for Decimal-0.5.1..
[1 of 1] Compiling Data.Decimal     ( src/Data/Decimal.hs, dist/build/Data/Decimal.o, dist/build/Data/Decimal.dyn_o )

src/Data/Decimal.hs:69:24: error:
    Operator applied to too few arguments: !
   |
69 |       decimalPlaces :: ! Word8,
   |                        ^
cabal: Failed to build Decimal-0.5.1

This pull request fixes the compilation error, making Decimal compatible with ghc-9.0.

@PaulJohnson PaulJohnson merged commit 495b584 into PaulJohnson:master Oct 12, 2020
@simonmichael
Copy link
Contributor

Could we have a hackage release with this ?

@PaulJohnson
Copy link
Owner

Version 0.5.2 now up on Hackage.

@simonmichael
Copy link
Contributor

simonmichael commented Mar 14, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants