fix(pat-inject): Allow to submit invalid forms when form/novalidate. #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respect the form[novalidate] and button[formnovalidate] attributes and allow the submission of invalid forms. This is necessary if a cancel button is a submit button and needs to be allowed to submit even if the form input is invalid.
thet
force-pushed
the
scrum-2646--novalidate
branch
from
6682236
to
993d27d
Compare
mauritsvanrees
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect the form[novalidate] and button[formnovalidate] attributes and allow the submission of invalid forms.
This is necessary if a cancel button is a submit button and needs to be allowed to submit even if the form input is invalid.
Note: there is one skipped test due to lack of
formnovalidatesupport in jsDOM. However, I have tested it manually on a testing page. The fix seems to work in Firefox.TODO:
button[formnovalidate]support.