Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #535 for hiding the keyboard #542

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

Varsha-Kulkarni
Copy link
Contributor

I've read and understood our contributing guidelines;
https://github.com/patilshreyas/NotyKT/blob/master/CONTRIBUTING.md

Summary

When a new note is saved or an existing note is edited successfully, the keyboard was not being dismissed.
This fixes the issue #535

Description for the changelog

  • After successful login, when navigated to AddNewNoteFragment/NoteDetailFragment to add or edit a note, once successfully saving the note when navigated back to NotesListFragment, the soft keyboard is retained. The issue is fixed in this PR.

Checklist

  • Build and linting is passing.
  • This change is not breaking existing flow of a system.
  • I have written test case for this change.
  • This change is tested from all aspects.
  • Implemented any new third-party library (Which not existed before this change).

Copy link
Owner

@PatilShreyas PatilShreyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Varsha-Kulkarni for raising this PR. It looks good to me 👍🏻. Just a question, the same implementation is required for compose app?

@PatilShreyas PatilShreyas added this to the v2.1.0 milestone Oct 5, 2022
@PatilShreyas PatilShreyas changed the base branch from master to dev-v2.1.0 October 5, 2022 12:33
@PatilShreyas PatilShreyas merged commit 6f26507 into PatilShreyas:dev-v2.1.0 Oct 5, 2022
@Varsha-Kulkarni
Copy link
Contributor Author

On composeapp, when we add a new note, keyboard is dismissed on saving and navigating back, but when we edit existing it isn't. Also we can use LocalSoftwareKeyboardController to hide keyboard, right?

@PatilShreyas
Copy link
Owner

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Keyboard retains after navigating back from Add Note or Note detail screen
2 participants