Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp architecture of NotyKT Android app #397

Closed
PatilShreyas opened this issue Feb 13, 2022 · 1 comment · Fixed by #398 or #408
Closed

Revamp architecture of NotyKT Android app #397

PatilShreyas opened this issue Feb 13, 2022 · 1 comment · Fixed by #398 or #408
Assignees
@PatilShreyas
Labels
enhancement New feature or request
Milestone
v2.0.0

Comments

@PatilShreyas
Copy link
Owner

The states management is becoming a problem in the android app due to maintaining two different variants of the android app i.e. simple app and compose app. Revamp architecture in such a way that both the apps will be dependent on common app module for data and state rather than maintaining their own state
@PatilShreyas PatilShreyas added the enhancement New feature or request label Feb 13, 2022
@PatilShreyas PatilShreyas self-assigned this Feb 13, 2022
@PatilShreyas PatilShreyas added this to the v1.4.0 milestone Feb 13, 2022
@PatilShreyas PatilShreyas mentioned this issue Feb 13, 2022
Merged
5 tasks
@PatilShreyas PatilShreyas linked a pull request Feb 13, 2022 that will close this issue
[Android] Revamp architecture and refactor android app module #398
Merged
5 tasks
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Add test utilities for testing ViewModel
26c4ecc
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Bump Kotest version
b30a0a1
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Refactor LoginViewModel and test
a0d459d
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Refactor RegisterViewModelTest
0324d5d
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Refactor AddNoteViewModelTest
6749eb3
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Remove unused annotations
879acf9
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Refactor NotesViewModelTest
ac3debb
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Refactor NoteDetailViewModelTest
18346d6
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Reformat with ktlint
e1fa8a3
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Add a test case in NoteDetailViewModelTest
6517f3b
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Update tests for NotyTaskManagerImpl
bad8976
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Fix condition for verifying terminal state of TaskState
ec2f2c6
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Reformat with ktlint
fc406fd
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Move note card and listing component to appropriate package
b05b339
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Remove unused UIDataState
71a68a8
PatilShreyas added a commit that referenced this issue Feb 13, 2022
@PatilShreyas
#397 | Provide doc for Either class
ced2b9e
PatilShreyas added a commit that referenced this issue Feb 16, 2022
@PatilShreyas
#397 | Add support doc for resetState method in AddNoteViewModel.kt
0d7cdef
PatilShreyas added a commit that referenced this issue Feb 16, 2022
@PatilShreyas
#397 | Add support doc for field isNoteLoaded in NoteDetailFragment.kt
7cdf19c
PatilShreyas added a commit that referenced this issue Feb 16, 2022
@PatilShreyas
#397 | Add support doc for method getNoteById() in NotesDao.kt
8f945d6
PatilShreyas added a commit that referenced this issue Feb 16, 2022
@PatilShreyas
#397 | Remove logging from observeConnectivity
ae65baf
PatilShreyas added a commit that referenced this issue Feb 16, 2022
@PatilShreyas
#397 | Disable or enable swipe on connectivity state
02bd00e
PatilShreyas added a commit that referenced this issue Feb 16, 2022
@PatilShreyas
#397 | Refactor lambda name: onSignupClick
1d50ef0
PatilShreyas added a commit that referenced this issue Feb 16, 2022
@PatilShreyas
#397 | Fix: use viewLifecycle instead of fragment lifecycle in BaseFr…
4e60001 
…agment.kt
PatilShreyas added a commit that referenced this issue Feb 20, 2022
@PatilShreyas
#397 | Add docs for architecture revamp
219b5c8
PatilShreyas added a commit that referenced this issue Feb 20, 2022
@PatilShreyas
#397 | Add release notes for v2.0.0
fe8c519
@PatilShreyas PatilShreyas mentioned this issue Feb 20, 2022
Merged
@PatilShreyas PatilShreyas linked a pull request Feb 20, 2022 that will close this issue
Release v2.0.0 #408
Merged
@PatilShreyas
Copy link
Owner Author

Read more about the refactoring here: https://patilshreyas.github.io/NotyKT/#/pages/noty-android/architecture-revamp-v2.0.0

@PatilShreyas PatilShreyas moved this to Done in NotyKT Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PatilShreyas PatilShreyas

Labels
enhancement New feature or request
Projects
NotyKT
Status: Done
Milestone
v2.0.0
1 participant
@PatilShreyas