Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up GitHub Actions to compile PathVisio #203

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Set up GitHub Actions to compile PathVisio #203

merged 3 commits into from
Aug 29, 2023

Conversation

larsgw
Copy link
Contributor

@larsgw larsgw commented Aug 28, 2023

Fix #202

@larsgw
Copy link
Contributor Author

larsgw commented Aug 28, 2023

The Travis CI configuration also built against OpenJDK 11 and 14. This uses Temurin, which does not have 14. However, neither 11 nor 17 (the next LTS in Temurin) compile.

@mkutmon
Copy link
Collaborator

mkutmon commented Aug 28, 2023

is there a possibility to build against JDK 8? Since PV4 will be a completely different codebase and repo, I don't think it's needed to build this repo against higher Java.

@larsgw
Copy link
Contributor Author

larsgw commented Aug 28, 2023

This builds against JDK 8. I just wanted to mention that the old .travis.yml also seemed to build against 11 and 14, so if that is needed, it needs to be figured out.

@mkutmon
Copy link
Collaborator

mkutmon commented Aug 29, 2023

ah perfect! thanks! just got confused... :)

@mkutmon mkutmon merged commit 471fde3 into PathVisio:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up one or more GitHub Actions to compile PathVisio
2 participants
@larsgw @mkutmon