Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting sorted metabolite/gene product in search bar #90

Open
larsgw opened this issue May 4, 2018 · 4 comments
Open

Selecting sorted metabolite/gene product in search bar #90

larsgw opened this issue May 4, 2018 · 4 comments

Comments

@larsgw
Copy link
Contributor

larsgw commented May 4, 2018

Selecting a metabolite/gene product/etc in the search bar will, if the list is sorted, select the entity at that index but in the unsorted list.

Reproduce

  1. Create a metabolite data node
  2. Open properties
  3. Search, e.g. "glucose"
  4. Sort by name
  5. Select the first item ((E)-1-O-Cinnamoyl-beta-D-glucose, HMDB30293)

The selected item is now alpha-D-Glucose (CHEBI:10242).

System

Program Version
PathVisio 3.3.0
openjdk 1.8.0_162
@larsgw
Copy link
Contributor Author

larsgw commented May 4, 2018

Probably introduced by 618f571 (since the sorting functionality was introduced there.) Also, this is probably relevant: https://stackoverflow.com/q/4151850/5095300.

larsgw added a commit to larsgw/pathvisio that referenced this issue May 4, 2018
larsgw added a commit to larsgw/pathvisio that referenced this issue May 4, 2018
@DeniseSl22
Copy link
Collaborator

HI @larsgw , thank you for fixing this :) We (@mkutmon and me) are working of a pre-release of PV, and your fix works great! We'll add you to the contributors list!

@khanspers
Copy link
Collaborator

I am seeing this bug again, aka after sorting a list of search results and selecting one, the selection actually corresponds to the unsorted list (or at least that is what I assume, it is not selecting the right item).

@khanspers khanspers reopened this Jun 21, 2019
@mkutmon
Copy link
Collaborator

mkutmon commented Jun 22, 2019

Actually I am not sure this is in the current release yet. I am still waiting for the signing certificate to get PathVisio 3.4.0 out, but I will test it again in the pre-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants