Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for many Runecraft Enchants #8217

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Conversation

LocalIdentity
Copy link
Contributor

@LocalIdentity LocalIdentity commented Aug 19, 2024

Adds support for the following mods:
Gain Arcane Surge after Spending a total of 200 Life
Adds 5% of your Maximum Energy Shield as Cold Damage to Attacks with this Weapon
Adds 5% of your Maximum Mana as Fire Damage to Attacks with this Weapon
Damage cannot be Reflected
Mana Leech from Hits with this Weapon is Instant
Chaos Damage with Hits is Lucky
(7-10)% increased Fire Damage per 1% Fire Resistance above 75%

Mods that still need support:
Haunted by Tormented Spirits
Trigger a Socketed Fire Spell on Hit, with a 0.25 second Cooldown -- Handled in another PR
Gain Flaming, Icy or Crackling Runesurge at random for 4 seconds every 10 seconds
Gain a random shrine buff every 10 seconds

Fixes #8213

Adds support for the following mods:
Gain Arcane Surge after Spending a total of 200 Life
Adds 5% of your Maximum Energy Shield as Cold Damage to Attacks with this Weapon
Adds 5% of your Maximum Mana as Fire Damage to Attacks with this Weapon
Damage cannot be Reflected
Mana Leech from Hits with this Weapon is Instant
Chaos Damage with Hits is Lucky
(7-10)% increased Fire Damage per 1% Fire Resistance above 75%

Mods that still need support:
Haunted by Tormented Spirits
Trigger a Socketed Fire Spell on Hit, with a 0.25 second Cooldown
Gain Flaming, Icy or Crackling Runesurge at random for 4 seconds every 10 seconds
Gain a random shrine buff every 10 seconds
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Aug 19, 2024
@LocalIdentity LocalIdentity merged commit f6ee17f into dev Aug 31, 2024
1 of 2 checks passed
@LocalIdentity LocalIdentity deleted the add_runecraft-mods branch August 31, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bow Runesmithing Enchantment Not Supported
1 participant