Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a docker container for tests #8199

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Aug 17, 2024

Description of the problem being solved:

Implements a docker container with specific versions of tools needed to run tests. Updates current tests workflow to use it fixing luajit missing issue.

Lines containing references to ghcr.io/paliak/pathofbuilding-tests:latest will need to be updated after an image is published under POB org.

@Paliak Paliak added enhancement New feature, calculation, or mod technical Hidden from release notes labels Aug 17, 2024
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for fixing it, sorry it took so long to merge.

I'll build the docker container and edit those lines directly once it's done

@Wires77 Wires77 merged commit c70e9dd into PathOfBuildingCommunity:dev Jan 3, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod technical Hidden from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants