Fix limited processing flag not persisting through recursions causing crash #8192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8136
Description of the problem being solved:
The role of the limited processing flag on skills is to prevent infinite recursion loops that eventually cause a crash. The problem is that due to
calcs.initEnv
re-generatingactiveSkillList
the flag is lost. This causes issues when there are more than one skill requiring such as flag as the application of the flag will alternate allowing for infinite recursion.The proposed solution moves the flags from skills to a table in the root of the env table allowing for easier copying and querying of the flags deeper into the call stack. This solution is not ideal as preventing the recalculation of the
activeSkillList
would greatly speed things up but due to many data dependencies i have not found a good way to achieve that.Steps taken to verify a working solution: