Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Add 'Cast Time' to Calcs page for Warcries #8190

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Fix Add 'Cast Time' to Calcs page for Warcries #8190

wants to merge 3 commits into from

Conversation

n1tr0xs
Copy link
Contributor

@n1tr0xs n1tr0xs commented Aug 15, 2024 •
edited
Loading

Fixes #8079 .

Description of the problem being solved:

Currently there's no way to see warcries cast speed.

Steps taken to verify a working solution:

  • Add warcry skill gem.
  • Select it in 'Calcs'.
  • Check 'Attack/Cast Rate' section

Before screenshot:

image

After screenshot:

image

@n1tr0xs n1tr0xs marked this pull request as ready for review August 15, 2024 13:15
@n1tr0xs
Copy link
Contributor Author

n1tr0xs commented Aug 15, 2024

Because of warcries have cooldown, i haven't found a way to display the actual 'Use time'. =(

@Paliak
Copy link
Contributor

Paliak commented Aug 15, 2024

Because of warcries have cooldown, i haven't found a way to display the actual 'Use time'. =(

What do you need for the use time? Cooldown?

@Paliak Paliak added the enhancement New feature, calculation, or mod label Aug 15, 2024
@n1tr0xs
Copy link
Contributor Author

n1tr0xs commented Aug 16, 2024

Because of warcries have cooldown, i haven't found a way to display the actual 'Use time'. =(

What do you need for the use time? Cooldown?

I didn't get what use as breakdown or mod.
I tried to format output:Time, but this one shows 'cast time + cooldown'.

@Regisle
Copy link
Member

Regisle commented Aug 16, 2024

You would need to create an output in calc offense for the warcry time, its not stored in any outputs atm, but is calculated for exert uptime iirc

@n1tr0xs
Copy link
Contributor Author

n1tr0xs commented Aug 16, 2024 •
edited
Loading

I found WarcryCastTime in the outputs.
Thanks for the guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'Cast Time' to Calcs page for War Crys
3 participants
@n1tr0xs @Paliak @Regisle