-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tincture effect fixes #8151
base: dev
Are you sure you want to change the base?
Tincture effect fixes #8151
Conversation
8106642
to
231a1a2
Compare
Taking this out of draft as I have gotten rid of all the issues I found during testing, only remaining issue is the exporting of tincture items strips the "tincture" tag from the implicits as its not a real tag, unsure the best way to handle it (forcing the tag if the base type is a tincture seems the best?) I ended up removing the range scalar function as the call to it was becoming so long that all benefits of using a function other than code dedupe was gone, and as for code dedupe, the 3 places its needed all have slightly different requirements and so needing the cover all those adds a bunch of extra boilerplate into the function |
Fixes #8090 and #8039 .
Scales tincture items like jewellery with catalysts (this can easily be modified to also scale other items by modifiers effect like for heist bases or enchants)
Currently need to fix exporter (or how the mods are tagged) but also I am unsure if this is the best way to handle these, this seems like its not the optimal solution