Sort loadouts dropdown based on name + number #7759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Slusny <[email protected]>
|
Oh no: 600d1cd Yours might be more robust though |
Wires77
reviewed
Jul 21, 2024
Comment on lines
+977
to
+978
| local aText, aNum = a:match("^(.+) {%d+}$"), tonumber(a:match("{(%d+)}")) | ||
| local bText, bNum = b:match("^(.+) {%d+}$"), tonumber(b:match("{(%d+)}")) |
There was a problem hiding this comment.
Suggested change
| local aText, aNum = a:match("^(.+) {%d+}$"), tonumber(a:match("{(%d+)}")) | |
| local bText, bNum = b:match("^(.+) {%d+}$"), tonumber(b:match("{(%d+)}")) | |
| local aText, aNum = a:match("^(.+) {%w+}$"), tonumber(a:match("{(%d+)}")) | |
| local bText, bNum = b:match("^(.+) {%w+}$"), tonumber(b:match("{(%d+)}")) |
The identifier doesn't have to be a number and I think we still want to sort by name if it's not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the loadout order is kind of a mess so sort it by name and number if present so the order is at least consistent.
Link to a build that showcases this PR:
https://pobb.in/u/thedeathbeam/pf-poison-scourge-arrow
Before screenshot:
After screenshot: