Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed modifiers to "[Any Damage] with melee skills" not working for DoT #7735

Merged
merged 4 commits into from
Jul 21, 2024
Merged

fixed modifiers to "[Any Damage] with melee skills" not working for DoT #7735

merged 4 commits into from
Jul 21, 2024

Conversation

DieMango
Copy link
Contributor

Fixes #7705 .

Description of the problem being solved:

Changed the Flag of the mod "with melee skills" from:
ModFlag.melee -> SkillType.Melee

Steps taken to verify a working solution:

  • creating a custom modifier "100% increased physical damage with melee skills" (and with more)
  • check with all damage can ignite/poison and 100% bleed chance for all DoTs

Link to a build that showcases this PR:

Before screenshot:

After screenshot:

@DieMango DieMango changed the title fixed modifiers to "[Any Damage] with melee skills" not working for DoT, Issue #7705 fixed modifiers to "[Any Damage] with melee skills" not working for DoT Jul 20, 2024
@Paliak Paliak added the bug: calculation Numerical differences label Jul 20, 2024
@DieMango DieMango changed the title fixed modifiers to "[Any Damage] with melee skills" not working for DoT fixed modifiers to "[Any Damage] with melee skills" not working for DoT, Jul 21, 2024
@DieMango DieMango changed the title fixed modifiers to "[Any Damage] with melee skills" not working for DoT, fixed modifiers to "[Any Damage] with melee skills" not working for DoT and added support for Ambush skill Jul 21, 2024
@DieMango

This comment was marked as outdated.

Sign in to view
@LocalIdentity
Copy link
Contributor

@DieMango I can revert the commit for you and you can open another PR for the ambush changes

@DieMango
Copy link
Contributor Author

That would be perfect thank you.

@DieMango DieMango changed the title fixed modifiers to "[Any Damage] with melee skills" not working for DoT and added support for Ambush skill fixed modifiers to "[Any Damage] with melee skills" not working for DoT Jul 21, 2024
@DieMango
Copy link
Contributor Author

DieMango commented Jul 21, 2024 •
edited
Loading

@LocalIdentity I created a standalone branch and the PR for Ambush.
#7757

@LocalIdentity LocalIdentity merged commit 33d00e5 into PathOfBuildingCommunity:dev Jul 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees
No one assigned
Labels
bug: calculation Numerical differences
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

% more Physical Damage with Melee Skills not affecting ignite damage
3 participants
@DieMango @LocalIdentity @Paliak