Add supports for Multi mine/trap throws #7662
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Add support for various sources of additional mine and additional trap throws. This includes:
Support Gems:
Mods:
When throwing additional mines,
MineLayingSpeed
is reduced by 10% for each additional mine:output.MineLayingSpeed = output.MineLayingSpeed / (1 + (mineThrowCount - 1) * 0.1)
. I have tested this by capturing in-game footage, and the difference between the calculation and the captured footage is less than one frame. Please double-check and verify that the calculation is correct.For the "damage multiplier" of having multiple trap/mine throws, the current implementation overrides the speed with
skillData.timeOverride = output.MineLayingTime / output.MineThrowCount
for mines andskillData.timeOverride = output.TrapThrowingTime / output.TrapThrowCount
for traps.Note: Mine Detonation speed and Trap Triggered speed are not implemented and are not calculated for dps.
Additionally, I have added a calculation for trap-mine skill setups when having multiple traps and multiple mines per throw with
skillData.timeOverride = output.MineLayingTime / output.MineThrowCount / output.TrapThrowCount
. This applies to setups such asFire Trap -- High-Impact Mine -- Swift Assembly
.Steps taken to verify a working solution:
Ctr+F5
to rebuild ModCache.Link to a build that showcases this PR:
https://pobb.in/3PTJj4xjYx_K
Before screenshot:
After screenshot: