Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logic for generating uniques into export scripts #7245

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

sida-wang
Copy link
Contributor

@sida-wang sida-wang commented Jan 14, 2024

Description of the problem being solved:

Currently generated uniques are being processed on startup. This PR shifts the generation into the export scripts which will provide more transparency on what data PoB is reading in for these uniques.

Most of the logic from the shifted over from the existing Generated.lua with refactors where appropriate. A large part of the refactoring is shifting the extraction of mods for the uniques to be extracted from dat files rather than using Data.lua during runtime.

To-do:

  • Test and compare with existing implementation
  • Check if loadStatFile() should use a specific file L11. stat_descriptions.txt is sufficient for the mods on generated uniques.

Steps taken to verify a working solution:

  • Compared number of variants for each generated unique - differences outlined in notes below
  • Confirmed variant selection behaviour for each generated unique is appropriate

Notes

  • Forbidden Shako and Replica Forbidden Shako variants reduced by 2 due to Elemental Penetration not being an indexable support gem.
  • Skin of the Lords and Impossible Escape variants have reduced by 2 with the removal of Doomsday and Supreme Decadence (this should have been included in the exclusion list).

@sida-wang sida-wang added the enhancement New feature, calculation, or mod label Jan 14, 2024
@sida-wang sida-wang marked this pull request as draft January 14, 2024 11:23
@sida-wang sida-wang marked this pull request as ready for review January 16, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant