-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move logic for generating uniques into export scripts #7245
Open
sida-wang
wants to merge
14
commits into
PathOfBuildingCommunity:dev
Choose a base branch
from
sida-wang:feat-generated-dragonfangs
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Move logic for generating uniques into export scripts #7245
sida-wang
wants to merge
14
commits into
PathOfBuildingCommunity:dev
from
sida-wang:feat-generated-dragonfangs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Currently generated uniques are being processed on startup. This PR shifts the generation into the export scripts which will provide more transparency on what data PoB is reading in for these uniques.
Most of the logic from the shifted over from the existing
Generated.lua
with refactors where appropriate. A large part of the refactoring is shifting the extraction of mods for the uniques to be extracted from dat files rather than usingData.lua
during runtime.To-do:
loadStatFile()
should use a specific file L11.stat_descriptions.txt
is sufficient for the mods on generated uniques.Steps taken to verify a working solution:
Notes