Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for minions applying auras #6745

Merged

Conversation

Regisle
Copy link
Member

@Regisle Regisle commented Sep 24, 2023

Fixes #6739 .

Adds support for minions to apply auras. This still has the issue that only 1 relic is active at a time
image

@Paliak Paliak added the enhancement New feature, calculation, or mod label Sep 24, 2023
@Regisle Regisle changed the title Initial support for minions applying auras Improve support for minions applying auras Sep 29, 2023
@Regisle
Copy link
Member Author

Regisle commented Sep 29, 2023

The latest commit at the time I did this (merge in the spectre buffs into main buff loop) merges it inot the main loop, as there was already apparently support for these kind of buffs, this still works with the guardian relics and tested with the old buffs including arena masters presence
image

This also renames lightning golems wrath aura to avoid naming conflict that prevents the normal wrath aura from being applied, and supports it for the party tab

note that the curse and debuffs applied by minions are still not exported to party tab, which they probs should be at some point, but I would like a better way of de-duplicating the code first

@Regisle Regisle force-pushed the FixGuardianElementalRelics branch from dd7412c to bd8bd85 Compare December 1, 2023 09:29
@LocalIdentity LocalIdentity merged commit a3317a5 into PathOfBuildingCommunity:dev Dec 5, 2023
2 checks passed
@Regisle Regisle deleted the FixGuardianElementalRelics branch December 5, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guardian Elemental Relics not implemented
3 participants