Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sdlhints to 2.0.20 #33

Conversation

suve
Copy link
Collaborator

@suve suve commented Feb 12, 2022

This patch updates sdhints.inc to match SDL 2.0.20.
Will be followed up by a separate PR to clean up the file a bit (e.g. sort hints alphabetically).

suve added 10 commits February 12, 2022 15:06
This commit adds definitions for:
- SDL_HINT_AUDIO_CATEGORY
- SDL_HINT_AUDIO_DEVICE_APP_NAME
- SDL_HINT_AUDIO_DEVICE_STREAM_NAME
- SDL_HINT_AUDIO_DEVICE_STREAM_ROLE
- SDL_HINT_AUDIO_INCLUDE_MONITORS
- SDL_HINT_AUDIO_RESAMPLING_MODE
This commit adds definitions for:
- SDL_HINT_RENDER_BATCHING
- SDL_HINT_RENDER_LINE_METHOD
- SDL_HINT_RENDER_LOGICAL_SIZE_MODE
This commit adds definitions for:
- SDL_HINT_MOUSE_DOUBLE_CLICK_RADIUS
- SDL_HINT_MOUSE_DOUBLE_CLICK_TIME
- SDL_HINT_MOUSE_NORMAL_SPEED_SCALE
- SDL_HINT_MOUSE_RELATIVE_SCALING
- SDL_HINT_MOUSE_RELATIVE_SPEED_SCALE
- SDL_HINT_MOUSE_TOUCH_EVENTS
This commit adds definitions for:
- SDL_HINT_WAVE_FACT_CHUNK
- SDL_HINT_WAVE_RIFF_CHUNK_SIZE
- SDL_HINT_WAVE_TRUNCATION
This commit adds definitions for:
- SDL_HINT_LINUX_JOYSTICK_CLASSIC
- SDL_HINT_LINUX_JOYSTICK_DEADZONES
This commit adds definitions for:
- SDL_HINT_JOYSTICK_DEVICE
- SDL_HINT_JOYSTICK_HIDAPI
- SDL_HINT_JOYSTICK_HIDAPI_GAMECUBE
- SDL_HINT_JOYSTICK_HIDAPI_JOY_CONS
- SDL_HINT_JOYSTICK_HIDAPI_LUNA
- SDL_HINT_JOYSTICK_HIDAPI_PS4
- SDL_HINT_JOYSTICK_HIDAPI_PS4_RUMBLE
- SDL_HINT_JOYSTICK_HIDAPI_PS5
- SDL_HINT_JOYSTICK_HIDAPI_PS5_PLAYER_LED
- SDL_HINT_JOYSTICK_HIDAPI_PS5_RUMBLE
- SDL_HINT_JOYSTICK_HIDAPI_STADIA
- SDL_HINT_JOYSTICK_HIDAPI_STEAM
- SDL_HINT_JOYSTICK_HIDAPI_SWITCH
- SDL_HINT_JOYSTICK_HIDAPI_SWITCH_HOME_LED
- SDL_HINT_JOYSTICK_HIDAPI_XBOX
- SDL_HINT_JOYSTICK_RAWINPUT
- SDL_HINT_JOYSTICK_RAWINPUT_CORRELATE_XINPUT
- SDL_HINT_JOYSTICK_THREAD
This commit adds definitions for:
- SDL_HINT_VIDEO_X11_FORCE_EGL
- SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR
- SDL_HINT_VIDEO_X11_WINDOW_VISUALID
@Free-Pascal-meets-SDL-Website
Copy link
Collaborator

Looks great!

Two remarks:

  1. Could you add the version tag "2.0.20" alongside the include entry for sdlhints.inc in sdl2.pas, please?
  2. How to handle deprecated hints like SDL_HINT_MOUSE_FOCUS_CLICKTHROUGH? I opened an issue How to handle deprecated sdl2 functionality? #34 about this.

Best regards,
Matthias

suve added 19 commits February 13, 2022 19:34
This commit adds definitions for:
- SDL_HINT_GAMECONTROLLERCONFIG_FILE
- SDL_HINT_GAMECONTROLLERTYPE
- SDL_HINT_GAMECONTROLLER_IGNORE_DEVICES
- SDL_HINT_GAMECONTROLLER_IGNORE_DEVICES_EXCEPT
- SDL_HINT_GAMECONTROLLER_USE_BUTTON_LABELS
This commit adds definitions for:
- SDL_HINT_AUTO_UPDATE_JOYSTICKS
- SDL_HINT_AUTO_UPDATE_SENSORS
This commit adds definitions for:
- SDL_HINT_THREAD_FORCE_REALTIME_TIME_CRITICAL
- SDL_HINT_THREAD_PRIORITY_POLICYD
This commit adds definitions for:
- SDL_HINT_WINDOWS_FORCE_MUTEX_CRITICAL_SECTIONS
- SDL_HINT_WINDOWS_FORCE_SEMAPHORE_KERNEL
- SDL_HINT_WINDOWS_INTRESOURCE_ICON
- SDL_HINT_WINDOWS_INTRESOURCE_ICON_SMALL
- SDL_HINT_WINDOWS_USE_D3D9EXD
suve added 3 commits February 13, 2022 20:20
This commit adds definitions for:
- SDL_HINT_VIDEO_DOUBLE_BUFFER
- SDL_HINT_VIDEO_EGL_ALLOW_TRANSPARENCY
- SDL_HINT_VIDEO_EXTERNAL_CONTEXT
- SDL_HINT_VIDEO_WAYLAND_ALLOW_LIBDECOR
This commit adds definitions for:
- SDL_HINT_ANDROID_BLOCK_ON_PAUSE
- SDL_HINT_ANDROID_BLOCK_ON_PAUSE_PAUSEAUDIO
- SDL_HINT_ANDROID_TRAP_BACK_BUTTON
This commit adds definitions for:
- SDL_HINT_QTWAYLAND_CONTENT_ORIENTATION
- SDL_HINT_QTWAYLAND_WINDOW_FLAGS
@suve suve marked this pull request as ready for review February 13, 2022 19:27
Copy link
Collaborator

@Free-Pascal-meets-SDL-Website Free-Pascal-meets-SDL-Website left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for merge but would you like to add the version tag (see my remark 1. above) in sdl2.pas? If you like, I can do that, though.

A second thing I noticed, perhaps the SDL_HintPriority enum in line 1827 should be changed according to our code guidelines.

@Free-Pascal-meets-SDL-Website
Copy link
Collaborator

Thanks for this PR, suve!

@Free-Pascal-meets-SDL-Website Free-Pascal-meets-SDL-Website merged commit 9f1baaa into PascalGameDevelopment:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants