Prepare repo for .NET 8 #1243
Merged
Prepare repo for .NET 8 #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timbussmann this completes the address translation changes that you and me where part of a while back, can you take a look and see if I missed something? |
|
@SzymonPobiega seems like transactionscopes work for .NET when running on windows |
andreasohlund
commented
Sep 15, 2023
src/NServiceBus.Transport.SqlServer.TransportTests/ConfigureSqlServerTransportInfrastructure.cs
Outdated
Show resolved
Hide resolved
kentdr
reviewed
Sep 15, 2023
src/NServiceBus.Transport.SqlServer/SqlServerTransportInfrastructure.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Transport.SqlServer/SqlServerTransportInfrastructure.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Dan Kent <[email protected]>
timbussmann
approved these changes
Sep 18, 2023
src/NServiceBus.Transport.SqlServer.AcceptanceTests/ConfigureEndpointSqlServerTransport.cs
Outdated
Show resolved
Hide resolved
…e that isolation mode is preserved
andreasohlund
commented
Sep 20, 2023
bording
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream follow-up to preparing for .NET 8.