Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction timeout duration configuration for TransactionOptions in Outbox feature #901

Conversation

alexander-kucherov
Copy link
Contributor

@alexander-kucherov alexander-kucherov commented Mar 21, 2022

Added timeout configuration for TransactionScope in SqlOutboxFeature.
Would resolve issue #654

Currently outbox transaction scope always uses System.Transactions.Configuration.DefaultTimeout (1 minute) under .net core.

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2022

CLA assistant check
All committers have signed the CLA.

@alexander-kucherov alexander-kucherov force-pushed the feature/add-timeout-for-transactionoptions branch from 3223537 to 7d5d07a Compare March 21, 2022 08:25
@alexander-kucherov alexander-kucherov force-pushed the feature/add-timeout-for-transactionoptions branch from 7d5d07a to 2f68499 Compare March 21, 2022 08:59
@ramonsmits ramonsmits changed the title [Issue #654] Add transaction timeout configuration for TransactionOptions in SqlOutboxFeature Add transaction timeout duration configuration for TransactionOptions in Outbox feature Mar 24, 2022
Copy link
Member

@ramonsmits ramonsmits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramonsmits ramonsmits self-assigned this Mar 24, 2022
Add check - Timeout requested is longer than the maximum value for this machine
@alexander-kucherov
Copy link
Contributor Author

alexander-kucherov commented Mar 24, 2022

alexander-kucherov and others added 2 commits March 25, 2022 17:07
add parameter for broken tests
@alexander-kucherov
Copy link
Contributor Author

@ramonsmits , could you check CI pipeline? There is something wrong with "Check for secrets" step.

@ramonsmits
Copy link
Member

@ramonsmits , could you check CI pipeline? There is something wrong with "Check for secrets" step.

@alexander-kucherov External PR's are not fully build as these could have malicious changes. I'll clone the branch Tomorrow in our repo so that the build can run.

@stale
Copy link

stale bot commented Apr 29, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 29, 2022
@ramonsmits
Copy link
Member

ramonsmits commented May 2, 2022

@ramonsmits ramonsmits closed this May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants