-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transaction timeout duration configuration for TransactionOptions in Outbox feature #901
Conversation
3223537
to
7d5d07a
Compare
7d5d07a
to
2f68499
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramonsmits , Thanks! I've just added this validation. |
src/SqlPersistence/Outbox/TransactionScopeSqlOutboxTransaction.cs
Outdated
Show resolved
Hide resolved
src/SqlPersistence/Outbox/TransactionScopeSqlOutboxTransaction.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ramon Smits <[email protected]>
add parameter for broken tests
@ramonsmits , could you check CI pipeline? There is something wrong with "Check for secrets" step. |
@alexander-kucherov External PR's are not fully build as these could have malicious changes. I'll clone the branch Tomorrow in our repo so that the build can run. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Added timeout configuration for TransactionScope in SqlOutboxFeature.
Would resolve issue #654
Currently outbox transaction scope always uses
System.Transactions.Configuration.DefaultTimeout
(1 minute) under .net core.