Make monitoring radio send() signature consistent with radio.send #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an API tidyup that works towards all monitoring message sends taking a TaggedMonitoringMessage: callers of send are responsible for forming a tagged tuple.
khk-globus
approved these changes
Oct 31, 2024
Comment on lines
+204
to
+206
| def send(self, message: TaggedMonitoringMessage) -> None: | ||
| logger.debug("Sending message type {}".format(message[0])) | ||
| self.radio.send(message) |
There was a problem hiding this comment.
While here, "might as well" update the log.debug() call.
benclifford
added a commit
that referenced
this pull request
Nov 1, 2024
The is based on a review comment from @khk-globus on PR #3672
benclifford
added a commit
that referenced
this pull request
Nov 1, 2024
The is based on a review comment from @khk-globus on PR #3672
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
The is based on a review comment from @khk-globus on PR #3672 # Changed Behaviour logging formatting *should* come out the same but maybe not ## Type of change - Code maintenance/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an API tidyup that works towards all monitoring message sends taking a TaggedMonitoringMessage: callers of send are responsible for forming a tagged tuple.
Type of change