Remove interchange multiprocess log hack #3644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prioer to PR #3463, the interchange process was launched with multiprocessing fork and inherited the log configuration of the parent process. To give the interchange its own log file, a specific logger, called "interchange" was used. In PR #2307, this logger was configured to not propagate entries upwards, so that user defined root handlers in the parent process do not see interchange logs. Since #3463 this special configuration has no longer been necessary. See #3635 for a related change to signal handlers.
khk-globus
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to PR #3463, the interchange process was launched with multiprocessing fork and inherited the log configuration of the parent process.
To give the interchange its own log file, a specific logger, called "interchange" was used. In PR #2307, this logger was configured to not propagate entries upwards, so that user defined root handlers in the parent process do not see interchange logs.
Since #3463 this special configuration has no longer been necessary. See #3635 for a related change to signal handlers.
Changed Behaviour
This should not change any logging behaviour
Type of change