Use incluster config fallback for KubernetesProvider #3357

trey-stafford · 2024-04-16T16:46:14Z

Description

This PR supersedes #2503

See kubernetes-client/python#1005 for a good description of the issue.

Changed Behaviour

The KubernetesProvider now falls back to loading config in-cluster if a kube-config file is not found. This allows in-cluster submission of parsl jobs.

Fixes

Fixes # (issue)

Type of change

Choose which options apply, and delete the ones which do not apply.

Bug fix

mfisher87 · 2024-04-17T18:03:41Z

@benclifford do you have any thoughts on this CI failure? It also occurred on your PR #3359.

Failed to build radical.pilot
ERROR: Could not build wheels for radical.pilot, which is required to install pyproject.toml-based projects

benclifford · 2024-04-17T18:06:41Z

some exciting new build problem with radical's build/packaging. I tried briefly to recreate it on my laptop and did not have a problem, so I'll dig into it more deeply later in the week - I'm not working on Parsl today.

benclifford · 2024-04-17T18:07:25Z

(very possibly related to build system changes in Python 3.12 which were/are fairly aggressive)

mfisher87 · 2024-04-17T18:14:17Z

Oof. Thanks so much for providing that context and saving us from spinning our wheels on this! ❤️

benclifford · 2024-04-18T14:55:43Z

@trey-stafford I don't have rights to update your branch, so I can't merge the latest parsl master (and in general that will make it hard to get your branch up to date to merge it later). But, recent PR #3360 should fix the radical test failure you reported.

trey-stafford · 2024-04-18T16:32:39Z

@benclifford I've merged in master. Happy to do that again as needed!

Note that I also amended my first commit to this PR to properly credit @manning-ncsa for work contributed in the superseded PR, #2503 .

mfisher87 · 2024-04-18T16:34:03Z

@trey-stafford if you edit this PR can you enable "Allow maintainers to push"? Or is that only settable when opening the original PR? 🤔

benclifford · 2024-04-19T08:06:44Z

you did something weird perhaps with rebase that makes the diff look weird - I think I know what, and I think that will fix itself once master gets merged again - which is necessary for putting this PR on master anyway as our tests require the PR be up to date.

mfisher87 · 2024-04-19T09:05:57Z

I think I see what happened, we'll get it sorted on Monday! Thanks for your patience :)

mfisher87 · 2024-04-24T17:39:52Z

🚀 Sorry didn't get this done on Monday, but I think we're all fixed up now :)

benclifford · 2024-04-24T17:42:10Z

Can you comment a bit on what the exception reported to a user looks like? Say the user intends to do something with the config loaded by load_kube_config() but they mess it up in some way that raises an exception... does useful debugging information then get lost because that exception is immediately discarded?

mfisher87 · 2024-04-24T17:43:52Z

I have a couple meetings coming up to prepare for but we will get back to you in a couple hours!

mfisher87 · 2024-04-24T17:45:48Z

Would you like that context in the commit message for this commit? 4833fc2

benclifford · 2024-04-24T17:55:39Z

It doesn't really matter where you write it - if you have something really interesting to say, a comment in the code would be ok too, for example. Just more interested that someone thinks about it because I am always suspicious of too-easily-discarded exceptions.

mfisher87 · 2024-04-26T23:32:40Z

We pushed another change that we feel will help prevent a really confusing user experience if both local config and incluster config fail to load. We used an ExceptionGroup to handle this, but perhaps the better solution is to only re-raise the local config exception with a note that we tried both loading local and incluster config. The ExceptionGroup looks like this when raised:

Traceback (most recent call last):
  File "/home/mfisher/Projects/qgreenland-net/parsl-exploration/src/parsl/parsl/providers/kubernetes/kube.py", line 109, in __init__
    config.load_kube_config()
  File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/kube_config.py", line 815, in load_kube_config
    loader = _get_kube_config_loader(
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/kube_config.py", line 772, in _get_kube_config_loader
    raise ConfigException(
kubernetes.config.config_exception.ConfigException: Invalid kube-config file. No configuration found.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/mfisher/Projects/qgreenland-net/parsl-exploration/src/parsl/parsl/providers/kubernetes/kube.py", line 123, in __init__
    config.load_incluster_config()
  File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/incluster_config.py", line 121, in load_incluster_config
    try_refresh_token=try_refresh_token).load_and_set(client_configuration)
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/incluster_config.py", line 54, in load_and_set
    self._load_config()
  File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/incluster_config.py", line 62, in _load_config
    raise ConfigException("Service host/port is not set.")
kubernetes.config.config_exception.ConfigException: Service host/port is not set.

During handling of the above exception, another exception occurred:

  + Exception Group Traceback (most recent call last):
  |   File "/home/mfisher/Projects/qgreenland-net/parsl-exploration/run.py", line 104, in <module>
  |     config = get_parsl_config()
  |              ^^^^^^^^^^^^^^^^^^
  |   File "/home/mfisher/Projects/qgreenland-net/parsl-exploration/run.py", line 49, in get_parsl_config
  |     provider=KubernetesProvider(
  |              ^^^^^^^^^^^^^^^^^^^
  |   File "/home/mfisher/Projects/qgreenland-net/parsl-exploration/src/parsl/parsl/providers/kubernetes/kube.py", line 125, in __init__
  |     raise ExceptionGroup(
  | ExceptionGroup: Encountered errors loading kubernetes cluster configuration (2 sub-exceptions)
  +-+---------------- 1 ----------------
    | Traceback (most recent call last):
    |   File "/home/mfisher/Projects/qgreenland-net/parsl-exploration/src/parsl/parsl/providers/kubernetes/kube.py", line 109, in __init__
    |     config.load_kube_config()
    |   File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/kube_config.py", line 815, in load_kube_config
    |     loader = _get_kube_config_loader(
    |              ^^^^^^^^^^^^^^^^^^^^^^^^
    |   File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/kube_config.py", line 772, in _get_kube_config_loader
    |     raise ConfigException(
    | kubernetes.config.config_exception.ConfigException: Invalid kube-config file. No configuration found.
    +---------------- 2 ----------------
    | Traceback (most recent call last):
    |   File "/home/mfisher/Projects/qgreenland-net/parsl-exploration/src/parsl/parsl/providers/kubernetes/kube.py", line 123, in __init__
    |     config.load_incluster_config()
    |   File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/incluster_config.py", line 121, in load_incluster_config
    |     try_refresh_token=try_refresh_token).load_and_set(client_configuration)
    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |   File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/incluster_config.py", line 54, in load_and_set
    |     self._load_config()
    |   File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/incluster_config.py", line 62, in _load_config
    |     raise ConfigException("Service host/port is not set.")
    | kubernetes.config.config_exception.ConfigException: Service host/port is not set.
    +------------------------------------

And as we're typing this @trey-stafford called out that parsl needs to support 3.10, and ExceptionGroups are new in 3.11. After the change, you can see both root-cause exceptions in the chain:

Traceback (most recent call last):
  File "/home/mfisher/Projects/qgreenland-net/parsl-exploration/src/parsl/parsl/providers/kubernetes/kube.py", line 109, in __init__
    config.load_kube_config()
  File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/kube_config.py", line 815, in load_kube_config
    loader = _get_kube_config_loader(
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/kube_config.py", line 772, in _get_kube_config_loader
    raise ConfigException(
kubernetes.config.config_exception.ConfigException: Invalid kube-config file. No configuration found.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/mfisher/Projects/qgreenland-net/parsl-exploration/src/parsl/parsl/providers/kubernetes/kube.py", line 123, in __init__
    config.load_incluster_config()
  File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/incluster_config.py", line 121, in load_incluster_config
    try_refresh_token=try_refresh_token).load_and_set(client_configuration)
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/incluster_config.py", line 54, in load_and_set
    self._load_config()
  File "/home/mfisher/.miniconda3/envs/parsl-exploration/lib/python3.12/site-packages/kubernetes/config/incluster_config.py", line 62, in _load_config
    raise ConfigException("Service host/port is not set.")
kubernetes.config.config_exception.ConfigException: Service host/port is not set.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/mfisher/Projects/qgreenland-net/parsl-exploration/run.py", line 104, in <module>
    config = get_parsl_config()
             ^^^^^^^^^^^^^^^^^^
  File "/home/mfisher/Projects/qgreenland-net/parsl-exploration/run.py", line 49, in get_parsl_config
    provider=KubernetesProvider(
             ^^^^^^^^^^^^^^^^^^^
  File "/home/mfisher/Projects/qgreenland-net/parsl-exploration/src/parsl/parsl/providers/kubernetes/kube.py", line 125, in __init__
    raise config.config_exception.ConfigException(
kubernetes.config.config_exception.ConfigException: Failed to load both kube-config file and in-cluster configuration.

Co-Authored-By: Trey Stafford <[email protected]>

mfisher87 · 2024-04-26T23:45:36Z

@benclifford we think we've got things ready to go!

benclifford · 2024-04-27T06:48:04Z

ok cool. you still need to do something to let me update this branch, to fit in our merge process

benclifford · 2024-04-27T08:44:12Z

wrt your comment on using Python 3.11 features, in recent years our informal policy has been to support the same Python versions as are listed here as "bugfix" or "security", so under that model, no 3.11 features until near the end of 2026 - https://devguide.python.org/versions/

We have a low-key project going on to understand our usage a bit better, and my gut feeling is that with people using things like conda more and being less tied to system-level Python, we could probably drop support earlier (and so access newer features like ExceptionGroups earlier) - tagging @NishchayKarle who is working on that usage project to help him understand this use case for that work.

mfisher87 · 2024-04-27T11:40:02Z

ok cool. you still need to do something to let me update this branch, to fit in our merge process

Shoot. I think @trey-stafford has to do that, and he may not be available until Monday. I don't have an edit button even though the PR is from a repo I have write access to. As ugly as it is, I can create another fork and open a new PR and ensure the "allow maintainers to change" checkbox is ticket if you'd like to get this merged sooner than that.

Trey, when you get to it, this checkbox is towards the bottom of the right sidebar:

benclifford · 2024-04-28T10:16:51Z

@mfisher87 no super rush to mess around to get it merged

trey-stafford · 2024-04-29T14:44:35Z

ok cool. you still need to do something to let me update this branch, to fit in our merge process

Shoot. I think @trey-stafford has to do that, and he may not be available until Monday. I don't have an edit button even though the PR is from a repo I have write access to. As ugly as it is, I can create another fork and open a new PR and ensure the "allow maintainers to change" checkbox is ticket if you'd like to get this merged sooner than that.

Trey, when you get to it, this checkbox is towards the bottom of the right sidebar:

This option is not available. I think it's because this is an org-forked repo. This documentation suggests it is possible with "user-owned forks".

Maybe a new fork is the right path?

trey-stafford · 2024-04-29T15:11:46Z

Ok, I transferred the repo to my personal account and was able to enable edits and access by maintainers! @benclifford hopefully that does the trick!

mfisher87 · 2024-04-29T15:24:11Z

In retrospect, that makes sense, as checking that box would give maintainers of other projects access to org-wide secrets! 🤯 (there is no such thing as personal-account-wide secrets)

benclifford · 2024-04-29T16:32:38Z

ok that worked, so this will be in the next Parsl release happening in the next few hours. Thanks!

sophie-bui · 2024-05-20T19:48:18Z

👋 Hi @trey-stafford and @mfisher87! My name is Sophie and I'm Parsl's community manager.

We're trying to broadly understand how people are using Parsl and would appreciate it if either/both of you would fill out our quick survey: https://bit.ly/parsl-use-survey. Thanks in advance!

mfisher87 · 2024-05-21T17:23:45Z

Hey @sophie-bui thanks for asking for our input! I just filled it out.

benclifford changed the title ~~K8s use incluster config fallback~~ Use incluster config fallback for KubernetesProvider Apr 18, 2024

trey-stafford force-pushed the k8s-use-incluser-config-fallback branch from 82c02a1 to 9f63b39 Compare April 18, 2024 16:29

manning-ncsa and others added 2 commits April 24, 2024 11:37

Fallback to load_incluser_config if load_kube_config fails

4833fc2

Catch ConfigException for fallback to load_incluster_config

0e1fc95

mfisher87 force-pushed the k8s-use-incluser-config-fallback branch from 9f63b39 to 0e1fc95 Compare April 24, 2024 17:38

benclifford approved these changes Apr 24, 2024

View reviewed changes

benclifford mentioned this pull request Apr 26, 2024

Fall back to load_incluster_config() when load_kube_config() fails #2503

Closed

mfisher87 force-pushed the k8s-use-incluser-config-fallback branch from 549987a to 293fba0 Compare April 26, 2024 23:27

mfisher87 and others added 2 commits April 26, 2024 17:39

Explain incluster config exception and handle if both methods fail

20ad9c0

Co-Authored-By: Trey Stafford <[email protected]>

Make exception handling compatible with Python < 3.11

67cdca4

Co-Authored-By: Trey Stafford <[email protected]>

mfisher87 force-pushed the k8s-use-incluser-config-fallback branch from fbbd8d9 to 67cdca4 Compare April 26, 2024 23:40

Fix linter errors

bf05e3a

Co-Authored-By: Trey Stafford <[email protected]>

Merge branch 'master' into k8s-use-incluser-config-fallback

674b5dc

benclifford merged commit 0d1c30a into Parsl:master Apr 29, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use incluster config fallback for KubernetesProvider #3357

Use incluster config fallback for KubernetesProvider #3357

trey-stafford commented Apr 16, 2024

mfisher87 commented Apr 17, 2024

benclifford commented Apr 17, 2024

benclifford commented Apr 17, 2024

mfisher87 commented Apr 17, 2024

benclifford commented Apr 18, 2024

trey-stafford commented Apr 18, 2024

mfisher87 commented Apr 18, 2024

benclifford commented Apr 19, 2024

mfisher87 commented Apr 19, 2024 •

edited

Loading

mfisher87 commented Apr 24, 2024

benclifford commented Apr 24, 2024

mfisher87 commented Apr 24, 2024 •

edited

Loading

mfisher87 commented Apr 24, 2024

benclifford commented Apr 24, 2024

mfisher87 commented Apr 26, 2024 •

edited

Loading

mfisher87 commented Apr 26, 2024

benclifford commented Apr 27, 2024

benclifford commented Apr 27, 2024

mfisher87 commented Apr 27, 2024 •

edited

Loading

benclifford commented Apr 28, 2024

trey-stafford commented Apr 29, 2024

trey-stafford commented Apr 29, 2024

mfisher87 commented Apr 29, 2024 •

edited

Loading

benclifford commented Apr 29, 2024

sophie-bui commented May 20, 2024

mfisher87 commented May 21, 2024

Use incluster config fallback for KubernetesProvider #3357

Use incluster config fallback for KubernetesProvider #3357

Conversation

trey-stafford commented Apr 16, 2024

Description

Changed Behaviour

Fixes

Type of change

mfisher87 commented Apr 17, 2024

benclifford commented Apr 17, 2024

benclifford commented Apr 17, 2024

mfisher87 commented Apr 17, 2024

benclifford commented Apr 18, 2024

trey-stafford commented Apr 18, 2024

mfisher87 commented Apr 18, 2024

benclifford commented Apr 19, 2024

mfisher87 commented Apr 19, 2024 • edited Loading

mfisher87 commented Apr 24, 2024

benclifford commented Apr 24, 2024

mfisher87 commented Apr 24, 2024 • edited Loading

mfisher87 commented Apr 24, 2024

benclifford commented Apr 24, 2024

mfisher87 commented Apr 26, 2024 • edited Loading

mfisher87 commented Apr 26, 2024

benclifford commented Apr 27, 2024

benclifford commented Apr 27, 2024

mfisher87 commented Apr 27, 2024 • edited Loading

benclifford commented Apr 28, 2024

trey-stafford commented Apr 29, 2024

trey-stafford commented Apr 29, 2024

mfisher87 commented Apr 29, 2024 • edited Loading

benclifford commented Apr 29, 2024

sophie-bui commented May 20, 2024

mfisher87 commented May 21, 2024

mfisher87 commented Apr 19, 2024 •

edited

Loading

mfisher87 commented Apr 24, 2024 •

edited

Loading

mfisher87 commented Apr 26, 2024 •

edited

Loading

mfisher87 commented Apr 27, 2024 •

edited

Loading

mfisher87 commented Apr 29, 2024 •

edited

Loading