Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htex interchange exits badly when custom signal handlers are inherited from user workflow process #2628

Closed
benclifford opened this issue Mar 14, 2023 · 1 comment

Comments

@benclifford
Copy link
Collaborator

Describe the bug
If a user has installed custom unix signal handlers, the interchange might not exit properly at parsl shutdown (or other strange stuff might happen)

htex interchange shutdown happens via a SIGTERM sent to the interchange.

the interchange process inherits the signal handlers of its parent process (the main workflow process) because it is a multiprocessing fork process. this is probably the wrong thing to happen.

these signal handlers are not necessarily going to shut down the interchange, and may do other non-htex stuff.

debugged this with @yadu and kevin working on funcx

To Reproduce
install a signal handler that does not exit, in your workflow process before initialising parsl.
observe that the interchange process remains after the workflow process ends.

Expected behavior
the interchange should terminate when the main parsl process wants it to terminate

Environment
my laptop. mostly observed with funcx endpoint being the workflow process.

benclifford added a commit that referenced this issue Mar 15, 2023
The interchange should run with a default SIGTERM handler, rather
than the arbitrary one it inherits from a user workflow process.

Fixes issue #2628
benclifford added a commit that referenced this issue Mar 22, 2023
The interchange should run with a default SIGTERM handler, rather
than the arbitrary one it inherits from a user workflow process.

Fixes issue #2628
@benclifford
Copy link
Collaborator Author

this should be fixed by #2629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant