Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendations Block: Add "Open Links in New Tab" option #990

Merged
merged 4 commits into from
Jul 20, 2022

Conversation

acicovic
Copy link
Collaborator

@acicovic acicovic commented Jul 19, 2022

Description

This PR introduces a new "Open Links in New Tab" option in the Recommendation Block's settings.

Motivation and Context

Closes #712.

How Has This Been Tested?

  • Manual testing, including downgrade/upgrade path.
  • Automated E2E testing included within this PR.

Screenshots

image

Copy link

@luiztiago luiztiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment, great job!

@acicovic acicovic marked this pull request as ready for review July 20, 2022 07:14
@acicovic acicovic requested a review from a team as a code owner July 20, 2022 07:14
@acicovic
Copy link
Collaborator Author

Note: I've not included noreferrer on purpose, but we can discuss it if anyone thinks that it should be included.

Copy link
Contributor

@vaurdan vaurdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@acicovic acicovic merged commit df6dc2a into develop Jul 20, 2022
@acicovic acicovic deleted the add/recommendations-block-open-links-new-tab branch July 20, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommendations Block: Add an "Open links in new tab" setting
3 participants