Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCH Smart Linking: Fix CSS leaking from the Block Preview #2652

Merged
merged 6 commits into from
Jul 18, 2024
Merged

PCH Smart Linking: Fix CSS leaking from the Block Preview #2652

merged 6 commits into from
Jul 18, 2024

Conversation

vaurdan
Copy link
Contributor

@vaurdan vaurdan commented Jul 17, 2024

Description

As reported in #2627, some editor styles were leaking outside the block preview context in the Review modal. Although we were replacing all the body selectors with the specific .wp-parsely-preview-editor class, this was not enough to isolate some selectors, such as headings.

This PR changes that logic, and instead of simply replacing the body with the block preview class, it prefixes all the existing selectors with the .wp-parsely-preview-editor class, while also still replacing the body selector.

Motivation and context

How has this been tested?

Tested locally with four different themes. Each theme changed the resulting block preview, and both the Modal title and sidebar headers still retain their original styling.

Screenshots (if appropriate)

image

vaurdan added 5 commits July 17, 2024 14:12
@vaurdan
Fix CSS leaking to the modal and sidebar from the block preview compo…
cf6ea5a 
…nent
@vaurdan
Fix CSS leaking to the modal and sidebar from the block preview compo…
dc09bbd 
…nent
@vaurdan
Fix issue with CSS processing
e2431f3
@vaurdan
Merge remote-tracking branch 'origin/fix/smart-link-modal-css-leak' i…
d7393c2 
…nto fix/smart-link-modal-css-leak

# Conflicts:
#	build/content-helper/editor-sidebar-rtl.css
#	build/content-helper/editor-sidebar.asset.php
#	build/content-helper/editor-sidebar.css
#	build/content-helper/editor-sidebar.js
#	src/content-helper/editor-sidebar/smart-linking/review-modal/component-block-preview.tsx
#	src/content-helper/editor-sidebar/smart-linking/smart-linking.scss
@vaurdan
Add wrapper around the block preview as a CSS namespace
95a11ff
@vaurdan vaurdan added this to the 3.16.1 milestone Jul 17, 2024
@vaurdan vaurdan self-assigned this Jul 17, 2024
@vaurdan vaurdan requested a review from a team as a code owner July 17, 2024 15:39
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 17, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (4)
  • develop
  • add/.*
  • fix/.*
  • update/.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vaurdan vaurdan linked an issue Jul 17, 2024 that may be closed by this pull request
Smart Linking: Review modal alters styling in PCH Sidebar #2627
Closed
@acicovic
Copy link
Collaborator

Congrats on that work, this seems to be more complicated that I expected. Looking into it soon.

acicovic
acicovic reviewed Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@acicovic acicovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, 2 comments:

  • I think a couple of introduced @since DocBlocks might need to be 3.16.1 instead of 3.16.0.
  • Also wondering if we need a commend above useEffect.

@vaurdan
Copy link
Contributor Author

vaurdan commented Jul 18, 2024

@acicovic thank you, good catch :)
Fixed the wrong version in the @since docblocks, and also added an additional documentation block to the useEffect.

@vaurdan vaurdan requested a review from acicovic July 18, 2024 10:20
acicovic
acicovic approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@acicovic acicovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@acicovic acicovic merged commit 7c9d1a6 into prepare/3.16.1 Jul 18, 2024
33 of 34 checks passed
@acicovic acicovic deleted the fix/smart-link-modal-css-leak branch July 18, 2024 12:32
@vaurdan vaurdan mentioned this pull request Jul 18, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acicovic acicovic acicovic approved these changes

Assignees

@vaurdan vaurdan

Labels
Changelog: Fixed
Projects
None yet
Milestone
3.16.1
Development

Successfully merging this pull request may close these issues.

Smart Linking: Review modal alters styling in PCH Sidebar
2 participants
@vaurdan @acicovic