Fix: Make PCH Related Posts filters work for non-admins

Parsely · May 9, 2024 · f03c678 · f03c678
1 parent f70172e
commit f03c678
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/build/content-helper/editor-sidebar.asset.php b/build/content-helper/editor-sidebar.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-edit-post', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-plugins', 'wp-primitives', 'wp-url'), 'version' => 'eb6c5ec223f3254dbe5a');
+<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-edit-post', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-plugins', 'wp-primitives', 'wp-url'), 'version' => 'a16d4a6df7ef859f50df');
diff --git a/build/content-helper/editor-sidebar.js b/build/content-helper/editor-sidebar.js
diff --git a/src/content-helper/editor-sidebar/related-posts/component.tsx b/src/content-helper/editor-sidebar/related-posts/component.tsx
@@ -294,6 +294,7 @@ export const RelatedPostsPanel = (): JSX.Element => {
 		const noAuthorsExist = 0 === postData.authors.length;
 		const noTagsExist = 0 === postData.tags.length;
 		const noCategoriesExist = 0 === postData.categories.length;
+		const authorIsUnavailable = filterTypeIsAuthor && ! postData.authors.includes( filter.value );
 		const tagIsUnavailable = filterTypeIsTag && ! postData.tags.includes( filter.value );
 		const sectionIsUnavailable = filterTypeIsSection && ! postData.categories.includes( filter.value );
 
@@ -308,6 +309,8 @@ export const RelatedPostsPanel = (): JSX.Element => {
 			setFilter( { type: PostFilterType.Tag, value: postData.tags[ 0 ] } );
 		} else if ( sectionIsUnavailable ) {
 			setFilter( { type: PostFilterType.Section, value: postData.categories[ 0 ] } );
+		} else if ( authorIsUnavailable ) {
+			setFilter( { type: PostFilterType.Author, value: postData.authors[ 0 ] } );
 		}	else {
 			fetchPosts( FETCH_RETRIES );
 		}
@@ -376,7 +379,7 @@ export const RelatedPostsPanel = (): JSX.Element => {
 
 	// No filter data could be retrieved. Prevent the component from rendering.
 	if ( postData.authors.length === 0 && postData.categories.length === 0 &&
-			postData.tags.length === 0
+			postData.tags.length === 0 && isPostDataReady
 	) {
 		return (
 			<div className="wp-parsely-related-posts">

diff --git a/src/content-helper/editor-sidebar/related-posts/hooks.ts b/src/content-helper/editor-sidebar/related-posts/hooks.ts
@@ -56,7 +56,7 @@ export function usePostData(): PostData {
 
 		if ( Number.isInteger( authorId ) ) {
 			authorRecords = getEntityRecords(
-				'root', 'user', { include: [ authorId ] }
+				'root', 'user', { include: [ authorId ], context: 'view' }
 			) ?? undefined; // Coalescing null to undefined
 		} else {
 			authorRecords = null;
@@ -66,7 +66,7 @@ export function usePostData(): PostData {
 			categoryIds.every( Number.isInteger )
 		) {
 			categoryRecords = getEntityRecords(
-				'taxonomy', 'category', { include: categoryIds }
+				'taxonomy', 'category', { include: categoryIds, context: 'view' }
 			) ?? undefined; // Coalescing null to undefined
 		} else {
 			categoryRecords = null;
@@ -76,7 +76,7 @@ export function usePostData(): PostData {
 			tagIds.every( Number.isInteger )
 		) {
 			tagRecords = getEntityRecords(
-				'taxonomy', 'post_tag', { include: tagIds }
+				'taxonomy', 'post_tag', { include: tagIds, context: 'view' }
 			) ?? undefined; // Coalescing null to undefined
 		} else {
 			tagRecords = null;
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-edit-post', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-plugins', 'wp-primitives', 'wp-url'), 'version' => 'eb6c5ec223f3254dbe5a');
		<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-edit-post', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-plugins', 'wp-primitives', 'wp-url'), 'version' => 'a16d4a6df7ef859f50df');