Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBID-25: Add timezone and timezone offset filtering of impressions #11

Closed
wants to merge 49 commits into from

Conversation

icflournoy
Copy link

@icflournoy icflournoy commented May 19, 2020

icflournoy and others added 30 commits April 27, 2020 21:13
Add unit coverage for parrableIdSystem getId callback
PBID-14: Support US Privacy Framework
Migrating from legacy _parrable_eid cookie. The new cookie contains ibaOptout and ccpaOptout status fields
PBID-11: Integrate new compound cookie
…been suppressed

The userId/eids module will not consider our ID system for inclusion in the EIDs object if our ID value is not a string.
Unfortunately when we write our cookie without an EID (in the case where CCPA optout is true) then the deserialized EID value is undefined, to save space in the cookie.

So this is a hack that will return an empty string when Prebid is building the EIDs object so that we can still pass our optout status to those that require it to understand why our ID may be missing.
@icflournoy icflournoy requested a review from a team May 19, 2020 18:03
@icflournoy icflournoy self-assigned this May 19, 2020
@icflournoy icflournoy force-pushed the parrableIdSystem/PBID-25 branch from c5acbc5 to 0a4325a Compare May 27, 2020 13:47
PBID-39: Fill out userIdAsEids object with UID extended data (IBA and CCPA optout status)
Base automatically changed from parrableIdSystem/PBID-39 to parrableIdSystem/base June 9, 2020 12:50
@icflournoy icflournoy force-pushed the parrableIdSystem/PBID-25 branch from 0a4325a to be43de8 Compare June 9, 2020 13:06
@icflournoy icflournoy force-pushed the parrableIdSystem/PBID-25 branch from be43de8 to 46f535c Compare June 23, 2020 15:49
@icflournoy icflournoy changed the base branch from parrableIdSystem/base to master August 4, 2020 18:23
@icflournoy icflournoy closed this Sep 24, 2020
@icflournoy
Copy link
Author

This was merged upstream into master.

@icflournoy icflournoy deleted the parrableIdSystem/PBID-25 branch September 24, 2020 17:49
icflournoy pushed a commit that referenced this pull request Dec 18, 2020
* updates for first cut at bidder

* fix up height and width

* adds test spec

* remove hello_world from commit'

* updates to support native and fix issues found in initial review

* fix handling of new node in response for native vs banner

* updates to handle OpenRTB base

* updates to support RTB style calls

* updates to get back to parity

* updates to testing

* updates to test media type handling

* updates to handling testing

* updates to testing

* remove report file

* updates to fix up unit/spec tests

* updates to fix up unit/spec tests

* updates to fix up unit/spec tests

* updates to handling of gdpr

* Delete hello_world.html

* remove hellow-world-sample

* Pubwise 481 (#7)

* updates to support PubWise bid adapter, test cases and documentation

* updates to fix param tes

* Pubwise 481 (#8)

* fixes for unit testing

* remove unused variables and params

* Updates to Remove Unused Vars (#9)

* remove unused vars

* updates to fix up used and unsused params

* updates to fix up used and unsused params (#10)

* updates to fix up used and unsused params

* updates to remove usersync and add gvlid

* Pubwise 481 (#11)

* updates to remove usersync, add https, and add gvlid

* Update pubwiseBidAdapter.js

* updates to remove json, to remove options hit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants