config: exclude uncompressed assets #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@jfmcquade I think your initial suggestion didn't work because the asset_filter_function was set again on another line later in the config. After my commit this does seem to work, could you sense-check?
config.ts
Outdated
| @@ -17,6 +17,9 @@ config.google_drive.sheets_folder_ids = [ | |||
|
|
|||
| config.google_drive.assets_folder_ids = ["1abaL1QGd33NqqLoKuo2t9fVWKmh5ouM9", "1kLl5t3o4A2ssC2iC-lT2bp4u8BZZneSE"]; | |||
|
|
|||
| // Exclude uncompressed assets | |||
| config.app_data.assets_filter_function = (fileEntry) => !fileEntry.relativePath.includes("uncompressed") | |||
There was a problem hiding this comment.
I believe this doesn't work because there's already a line below setting the assets_filter_function to exclude draft folders
Ah, thanks for spotting my error! Yes this looks good, I can't approve because it's my PR, but looks good to merge |
esmeetewinkel
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates deployment config to exclude asset files that sit in folders with the name "uncompressed" on Google Drive. See IDEMSInternational/open-app-builder#1994 for the first use of this pattern