Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add floppy_content support #118

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

imranh2
Copy link
Contributor

@imranh2 imranh2 commented Aug 21, 2024

Add floppy_content support. Only 2 line change needed as all the other code is already there :)

@cjlapao
Copy link
Collaborator

cjlapao commented Aug 22, 2024

@imranh2 With what version of PD was this tested?

@imranh2
Copy link
Contributor Author

imranh2 commented Aug 22, 2024

@cjlapao latest I believe, why are you seeing issues?

% packer --version
Packer v1.11.2
% prlctl --version
prlctl version 19.4.1 (54985)

@cjlapao
Copy link
Collaborator

cjlapao commented Aug 22, 2024

@imranh2 I didn't test it yet but those functionalities should not work in PD19 as they were deprecated.

I will run some tests and will confirm if the function is still there.

@imranh2
Copy link
Contributor Author

imranh2 commented Aug 22, 2024

@cjlapao my testing has led to a floppy disk being created and attached with the right content with no noticeable deprecation warnings :)

If they are being deprecated then maybe it's best to focus on my other PR #119

@imranh2
Copy link
Contributor Author

imranh2 commented Oct 18, 2024

Tested working on

% prlctl --version                           
prlctl version 20.1.0 (55732)

@cjlapao
Copy link
Collaborator

cjlapao commented Oct 18, 2024

@bineesh-n Do you see any issues with adding this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants