-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add logic that lets users favorite a template #9713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
""" | ||
The user who's favorite templates were updated | ||
""" | ||
user: User! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Seems excessive to return the full user. I think it would be enough to return the updated template and favourite state.
I've moved the heart in the card to be slightly lower and to the right. For the custom label, we have a separate discussion in Slack around that. In the category labels, I think it is centred: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the custom label, once you and Terry have reached a decision in the Slack discussion, I can update this PR or wait for the "Custom" label to be reverted/changed.
On Chrome, it was centered for me, but I can see the 2px offset on Safari. I've pushed an update and now it's centered on Safari for me, too: |
Fix #9115
Loom demo: https://www.loom.com/share/d59162967e244522aa40b73290a9c9a8
AC