feat: add functionality to change templates during a retro #9544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickoferrall
changed the title
Dschoordsch
requested changes
Mar 20, 2024
| if (!isTeamMember(authToken, meeting.teamId)) { | ||
| return standardError(new Error('Team not found'), {userId: viewerId}) | ||
| } | ||
|
|
There was a problem hiding this comment.
-1 I think it would be good to check here for the correct stage and no reflections to avoid a situation where an outdated client could change the template still.
|
Super nice feature! IMHO the search box for the templates is a must here. We have way too many templates and finding the one you want might not be so pleasant. |
|
This has been through one Maintainer Review, and I've implemented the feedback. Georg is away on holiday now. I'm feeling good about the PR, so rather than waiting or requesting a review from someone else, I'll merge this. |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9088
Loom demo: https://www.loom.com/share/6a82a4500cac4bcc84bdefedc5d4741e
To test