feat: release AzureDevOps integration #9531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't hide it behind a feature flag anymore.
Modify the oauth flow slightly for a web app with a client secret. This will increase the lifetime of the authorization token and thus improve the user experience. An additional scope `offline_access` is necessary so we still get a refresh token.
Dschoordsch
commented
Mar 21, 2024
| @@ -40,8 +40,8 @@ class AzureDevOpsClientManager { | |||
| const providerState = Math.random().toString(36).substring(5) | |||
| const verifier = AzureDevOpsClientManager.generateVerifier() | |||
| const code = await AzureDevOpsClientManager.generateCodeChallenge(verifier) | |||
| const redirect = makeHref('/auth/ado') | |||
| const scope = '499b84ac-1321-427f-aa17-267ca6975798/.default' | |||
| const redirect = makeHref('/auth/ado2') | |||
There was a problem hiding this comment.
I switched our app to be a "web" app rather than "spa" so our access token gets a longer life-span. Because the redirects are not compatible, I just appended the 2 for now so it works straight after deploying.
| const redirect = makeHref('/auth/ado') | ||
| const scope = '499b84ac-1321-427f-aa17-267ca6975798/.default' | ||
| const redirect = makeHref('/auth/ado2') | ||
| const scope = '499b84ac-1321-427f-aa17-267ca6975798/.default offline_access' |
There was a problem hiding this comment.
Additional scope to still get a refresh token.
nickoferrall
approved these changes
Mar 25, 2024
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9408
Don't hide it behind a feature flag anymore.
Testing scenarios
Final checklist