Discussion thread links #4483
Merged
Discussion thread links #4483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickoferrall
commented
Dec 23, 2020
| @@ -164,6 +166,15 @@ const CommentEditor = (props: Props) => { | |||
| } | |||
| } | |||
| } | |||
| const links = linkify.match(text) | |||
There was a problem hiding this comment.
Initially I included this code in useLinks to keep things DRY but as it's only being repeated twice and as we need the above onPasteText code with the ref in this file, I felt it'd be best to keep it in the same function
|
this isn't working for me:
|
|
Interesting - I couldn't replicate that behaviour in the comment editor but if I followed steps 1-3 and then did ctrl+v into the task editor, the link was underlined but didn't work. I'm now trimming the whitespace which has resolved the task editor issue and I think it should resolve the comment editor issue too. |
|
success! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #4345.
Consideration
Copying and pasting between Draft JS editors doesn't work very well - font styles and hyperlinks aren't always maintained. This is a known issue in Draft JS. Someone from the community has created a PR with a suggested solution that hasn't been approved but I'd be happy to look into it.
However, I can't imagine that many of our users are copying & pasting text that they've just pasted so I suggest that I create an issue for this and prioritise it if any user tension pops up.
AC