Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding reactions in standup via mouse works more than once #10520

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented Nov 25, 2024

Description

Fixes #10512
The popover would close before the emoji was selected. Switching its mode to modal fixes this issue.

Demo

[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]

Testing scenarios

[Please list all the testing scenarios a reviewer has to check before approving the PR]

  • Scenario A

    • Step 1
    • Step 2...
  • Scenario B

    • Step 1
    • Step 2....

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

The popover would close before the emoji was selected. Switching its
mode to modal fixes this issue.
@@ -38,7 +38,7 @@ const AddReactjiButton = (props: Props) => {
onToggle(emojiId)
}
return (
<Popover.Root open={open} onOpenChange={onOpenChange}>
<Popover.Root open={open} onOpenChange={onOpenChange} modal>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a bug in the controlling behaviour, removing onOpenChange instead would have the same effect and still properly open and close.

@Dschoordsch Dschoordsch merged commit 8ddcd90 into master Nov 25, 2024
8 checks passed
@Dschoordsch Dschoordsch deleted the fix/10512/makeEmojiMartPopoverModal branch November 25, 2024 11:50
@Dschoordsch
Copy link
Contributor Author

@mattkrick fyi, in case I missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Adding a second reaction in Standups does not work
1 participant