Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn pg:build to deployment steps in README #10508

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

svenseeberg
Copy link

@svenseeberg svenseeberg commented Nov 21, 2024

Description

When not creating the PostgreSQL migrations, the yarn build command fails.

Fixes #10496

Demo

Freshly clone the repo and run yarn && yarn build. It will fail. When running yarn && yarn pg:build && yarn build the build succeeds.

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@svenseeberg svenseeberg changed the title Add yarn pg:buidld to deployment steps in README Add yarn pg:build to deployment steps in README Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant