Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use more detailed AI Summary for meetings #10501

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

nickoferrall
Copy link
Contributor

@nickoferrall nickoferrall commented Nov 19, 2024

Fix #10049

This PR updates the way we generate AI Summaries in meetings to use the more the detailed approach used in generate insights.

Now, when ending a retro meeting, we'll generate the AI Summary by using the same logic that dumps the data to a yaml file.

We're also using the updated prompt which encourages the use of links.

To test

  • End a retro meeting and see that the AI Summary looks good
  • Generate retro summaries for a team and see it works well with generateRetroSummaries

@@ -0,0 +1,134 @@
import getKysely from '../../../postgres/getKysely'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code comes from the previous generateMeetingSummary file

import canAccessAI from './canAccessAI'
import {transformRetroToAIFormat} from './transformRetroToAIFormat'

export const generateRetroSummary = async (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I think the name is misleading. I would assume this function does just generate a summary for a meeting and returns it. Instead it updates the table.
I would prefer if we'd change it to updateRetroSummary and also remove the return type, so it's less likely to be used wrongly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insights: use generateSummary instead of getSummary
2 participants