-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix builds for 0.7.0 #54
Comments
I think it caused by old CMake. |
ah. yeah i ran into this somewhere else. may need to compile it |
Given that @ZaWertun added the GenericVersion class which has since been used in a couple more places in bindgen/qt5, how about we simply don't make this check in cmake, but elsewhere? One option would be to simply extend find_clang.cr so that it accepts two versions from command line and returns the result of comparison (done via GenericVersion) through its exit status. Or another alternative could be that we ourselves detect and set the c++ standard as part of find_clang rather than expecting cmake to detect and pass it. |
The issue that pops up now is:
Is it possible that |
probably not. i probably just introduced that build bug. |
Looks like builds now fail with
The culprit may be Lines 60 to 63 in 3f02883
It should be okay to drop linker flags here ( Lines 145 to 147 in 3f02883
|
Currently the builds are broken: https://travis-ci.org/github/Papierkorb/bindgen
The text was updated successfully, but these errors were encountered: